Repository navigation
Expose vector store search capabilities and enforce supported search modes - #74
Merged
spelech merged 6 commits intoOct 28, 2026
Merged
Conversation
- Add get_capabilities() to VectorStore base class and implementations in QdrantVectorStore, ChromaVectorStore, and PgVectorStore. - Include capabilities in stats and vector store config API payloads. - Explicitly reject unsupported search modes (e.g. lexical on Chroma or pgvector) with ValueError and ensure true lexical search does not invoke dense embedding calls. - Gracefully map default hybrid search requests to semantic search on dense-only vector stores. - Update SearchInspector UI component to fetch backend capabilities and gate search mode buttons and weighting controls accordingly. - Add backend-specific test coverage for capability reporting, search mode validation, and dense/lexical/hybrid behavior across Qdrant, Chroma, and PgVector. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Contributor
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Add get_capabilities() to VectorStore base class and implementations in QdrantVectorStore, ChromaVectorStore, and PgVectorStore. - Include capabilities in stats and vector store config API payloads. - Explicitly reject unsupported search modes (e.g. lexical on Chroma or pgvector) with ValueError and ensure true lexical search does not invoke dense embedding calls. - Gracefully map default hybrid search requests to semantic search on dense-only vector stores. - Update SearchInspector UI component to fetch backend capabilities and gate search mode buttons and weighting controls accordingly. - Set asyncio_default_fixture_loop_scope in pytest.ini to resolve pytest-asyncio deprecation warning in CI. - Add backend-specific test coverage for capability reporting, search mode validation, and dense/lexical/hybrid behavior across Qdrant, Chroma, and PgVector. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Owner
Author
|
@jules Please review and address the following items for this PR: Issues to Fix
How to Confirm the FixRun the following commands to confirm everything passes: cd frontend && npm run build && git status
pytest tests/backend/test_vector_store_chroma.py tests/test_pgvector_store.py -v
python3 scripts/generate_requirements.py
pytest tests/backend/test_requirements_sync.py |
- Add get_capabilities() to VectorStore base class and implementations in QdrantVectorStore, ChromaVectorStore, and PgVectorStore. - Include capabilities in stats and vector store config API payloads. - Explicitly reject unsupported search modes (e.g. lexical on Chroma or pgvector) with ValueError and ensure true lexical search does not invoke dense embedding calls. - Gracefully map default hybrid search requests to semantic search on dense-only vector stores. - Update SearchInspector UI component to fetch backend capabilities and gate search mode buttons and weighting controls accordingly. - Set asyncio_default_fixture_loop_scope in pytest.ini to resolve pytest-asyncio deprecation warning in CI. - Add backend-specific test coverage for capability reporting, search mode validation, and dense/lexical/hybrid behavior across Qdrant, Chroma, and PgVector. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
- Add get_capabilities() to VectorStore base class and implementations in QdrantVectorStore, ChromaVectorStore, and PgVectorStore. - Include capabilities in stats and vector store config API payloads. - Explicitly reject unsupported search modes (e.g. lexical on Chroma or pgvector) with ValueError and ensure true lexical search does not invoke dense embedding calls. - Gracefully map default hybrid search requests to semantic search on dense-only vector stores. - Update SearchInspector UI component to fetch backend capabilities and gate search mode buttons and weighting controls accordingly. - Set asyncio_default_fixture_loop_scope in pytest.ini to resolve pytest-asyncio deprecation warning in CI. - Add backend-specific test coverage for capability reporting, search mode validation, and dense/lexical/hybrid behavior across Qdrant, Chroma, and PgVector. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
- Add get_capabilities() to VectorStore base class and implementations in QdrantVectorStore, ChromaVectorStore, and PgVectorStore. - Include capabilities in stats and vector store config API payloads. - Explicitly reject unsupported search modes (e.g. lexical on Chroma or pgvector) with ValueError and ensure true lexical search does not invoke dense embedding calls. - Gracefully map default hybrid search requests to semantic search on dense-only vector stores. - Update SearchInspector UI component to fetch backend capabilities and gate search mode buttons and weighting controls accordingly. - Set asyncio_default_fixture_loop_scope in pytest.ini to resolve pytest-asyncio deprecation warning in CI. - Add dispose_global_engine() in database engine and cleanup in temp_mcp_db fixture to prevent SQLite database lock contention in CI. - Add backend-specific test coverage for capability reporting, search mode validation, and dense/lexical/hybrid behavior across Qdrant, Chroma, and PgVector. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposed search capabilities across vector store backends (Qdrant, Chroma, PgVector), validated search modes to reject unsupported modes (e.g. lexical search on dense-only backends), mapped default hybrid mode to semantic on dense-only stores, and updated SearchInspector UI and test suites.
Fixes #56
PR created automatically by Jules for task 10161170291051937970 started by @spelech